Re: [PATCH] python: fix error handling

Subject: Re: [PATCH] python: fix error handling

Date: Mon, 23 Jan 2012 12:24:35 +0200

To: Justus Winter, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, 22 Jan 2012 14:09:35 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
> Before 3434d1940 the return values of libnotmuch functions were
> declared as c_void_p and the code checking for errors compared the
> returned value to None, which is the ctypes equivalent of a NULL
> pointer.
> 
> But said commit wrapped all the data types in python classes and the
> semantic changed in a subtle way. If a function returns NULL, the
> wrapped python value is falsish, but no longer equal to None.
> 
> Backported from master to 0.11.
> ---

LGTM.

Tomi

Thread: