Re: [PATCH v2 0/3] Better id: link buttonization

Subject: Re: [PATCH v2 0/3] Better id: link buttonization

Date: Wed, 14 Nov 2012 10:32:19 +0200

To: Ethan Glasser-Camp, Austin Clements, notmuch@notmuchmail.org

Cc: sascha-ml-reply-to-2012-4@silbe.org

From: Tomi Ollila


On Wed, Nov 14 2012, Ethan Glasser-Camp wrote:

> Austin Clements <amdragon@MIT.EDU> writes:
>
>> This is v2 of id:"1351650561-7331-1-git-send-email-amdragon@mit.edu".
>> This makes Jani's suggested additions to the regexp and adds support
>> for RFC 2392 mid: links, as suggested by Sascha.
>
> This series looks fine to me.

LGTM too. 

although this is different than others in test/emacs:

 +test_expect_equal_file EXPECTED OUTPUT

(grep test_expect_equal_file test/emacs)

The diff output in case of failure makes more sense when the args
are in this order -- but probably that should be changed
bu changing the arg handling order in test_expect_equal_file
(to be consistent with test_expect_equal) and then change the order
in the "remaining" uses of test_expect_equal_file EXPECTED OUTPUT.

> Ethan

Tomi

Thread: