Re: [Patch (rebased) 0/2] contrib: pick: remove an unused variable

Subject: Re: [Patch (rebased) 0/2] contrib: pick: remove an unused variable

Date: Mon, 26 Aug 2013 21:36:01 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Aug 25 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> This is a rebased version of
> id:1372712861-13515-1-git-send-email-markwalters1009@gmail.com.
>  
> When documenting notmuch-pick-worker I realised that
> notmuch-pick-buffer-name was an essentially unused argument: it is
> only used to reset itself on refresh.
>
> (Possibly this was a mis-copy from notmuch-show or possibly a left
> over from refesh used kill-buffer instead of erase-buffer.)
>
> In any case we might as well remove it and then document the function.

LGTM.

Tomi

>
> Best wishes
>
> Mark
>
> Mark Walters (2):
>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name
>   contrib: pick: add docstring for notmuch-pick-worker
>
>  contrib/notmuch-pick/notmuch-pick.el |   19 ++++++++-----------
>  1 files changed, 8 insertions(+), 11 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: