On Sun, May 08 2016, David Bremner <david@tethera.net> wrote:

> This obsoletes
>
>      id:1462065879-29860-1-git-send-email-david@tethera.net

looks pretty good & tests pass. one problem though, rest are nits:


;; This buffer is for notes you don't want to save, and for Lisp evaluation.
;; If you want to create a file, visit that file with C-x C-f,
;; then enter the text in that file's own buffer.


*** in id:1462665889-17121-2-git-send-email-david@tethera.net

+                  -DHAVE_XAPIAN_FIELD_PROCESSOR=\$(HAVE_XAPIAN_PROCESSOR) \\

build gives compile /warning/ there, unfortunately this is not fatal and
therefore can go unnoticed. -Wundef would do the same, complain about
undefined macro but would not be fatal.

then, some more nits:


*** id:1462665889-17121-4-git-send-email-david@tethera.net

+_notmuch_config_list_options () {


*** id:1462665889-17121-8-git-send-email-david@tethera.net

+typedef enum dump_includes {
+    DUMP_INCLUDE_TAGS=1,
+    DUMP_INCLUDE_CONFIG=2,
+} dump_include_t;

print_dump_header () has some empty lines before closing '}'


*** id:1462665889-17121-9-git-send-email-david@tethera.net

+process_config_line(notmuch_database_t *notmuch, const char* line){

+    val_p = strtok_len_c(key_p+key_len, delim, &val_len);                      



+    int include=0;


*** id:1462665889-17121-12-git-send-email-david@tethera.net

+/* query-fp.cc -  "query:" field processor glue glue


id:1462665889-17121-13-git-send-email-david@tethera.net

+_notmuch_config_list_built_with () {