On Sun, Oct 31 2021, David Bremner wrote: > Tomi Ollila <tomi.ollila@iki.fi> writes: > >> setup.py and _build.py to refer some other files based on directory >> where setup.py is located (os.path.dirname(sys.argv[0]). >> >> Dropped bindings/python-cffi/version.txt and refer ../../version.txt >> instead -- _build.py already refers ../../lib so why have version.txt >> twice (with identical content). >> >> Dropped copying of bindings/python-cffi source files to the build >> directory bindings/python-cffi in configure. > > Apologies, I think I did not read this discussion very carefully > before. I guess [1] is an alternative to the first two points. I'm not > sure which approach is better. Mine is a bigger hammer, but maybe that > could be useful in the future? > > The patch at [1] does not (by itself) allow the third change, but > probably some similar hacking of setup.py, but using the newly created > _notmuch_config.py would work. > > Tomi, did you happen to test "pip install ." with your approach? I'm > afraid your patch doesn't (easily) apply anymore so I was too lazy to > test myself. IIRC my approaches had quite a few problems which I thought soon after emailing so probablhy your versions are better. Have to look... Tomi > > Cheers, > > db > > [1]: id:20211031100354.1697379-1-david@tethera.net > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org