On Thu, Nov 15 2012, david@tethera.net wrote:

> From: David Bremner <bremner@debian.org>
>
> This is again the work of uncrustify.
>
> I remember there is some controversy about "! foo" versus "!foo", but
> in context I think "! foo" looks OK. Also, for functions "! foo
> (blah)" seems better than "!foo (blah)".

Currently:
$ egrep '! ' *.c | wc
     19     108    1074
$ egrep '![^ =]' *.c | wc 
     41     250    2223

Anyway IIRC Carl preferred the ! foo format and the code might
have drifted away from that...

Whatever this choice will eventually be for "pure" notmuch code
should not affect what the code that can be considered as
external libraries should be formatted; e.g. parse-time-string
code should keep the formatting Jani prefers.

The uncrustify.cfg option 'sp_not' affects whether there is
space after ! or not -- and it can even be configured to 'ignore'
this case.

Tomi

// patch dropped.