Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time options

Subject: Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time options

Date: Sun, 01 May 2016 20:48:53 +0300

To: notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sat, Apr 30 2016, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> On Sat, Mar 26 2016, David Bremner <david@tethera.net> wrote:
>>
>>
>> ... note: if this notmuch_options_present () function prevails, fix
>> the later #if check ;D
>>
>> ... and
>>
>> void
>> _notmuch_config_list_options () {
>>     printf("options.compact=%s\n",
>> 	   HAVE_XAPIAN_COMPACT ? "true" : "false");
>>     printf("options.field_processor=%s\n",
>> 	   HAVE_XAPIAN_FIELD_PROCESSOR ? "true" : "false");
>> }
>>
>
> This I'm not so sure about. There's a subtle distinction between what is
> supported in the CLI and what is supported in the lib, and we really
> want the latter. So I do think _some_ library routine is needed.

Ah! this is the one thing I did not catch -- we need to know what _library_
supports from cli/bindings/whatnot. This makes most of the things I wrote
in my email irrelevant ;/ 

You seem to have sent new series so I stop commenting this and concentrate
on that...

Tomi


Thread: