Re: [PATCH] Drop deprecated/unused crypto.gpg_path

Subject: Re: [PATCH] Drop deprecated/unused crypto.gpg_path

Date: Wed, 19 Feb 2020 08:26:10 +0200

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Tomi Ollila


On Tue, Feb 18 2020, Daniel Kahn Gillmor wrote:

> crypto.gpg_path was only used when we built against gmime versions
> before 3.0.  Since we now depend on gmime 3.0.3 or later, it is
> meaningless.
>
> The removal of the field from the _notmuch_config struct would be an
> ABI change if that struct were externally exposed, but it is not, so
> it's safe to unilaterally remove it.
>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  bindings/python-cffi/tests/conftest.py | 2 --
>  doc/man1/notmuch-config.rst            | 8 --------
>  notmuch-config.c                       | 1 -
>  3 files changed, 11 deletions(-)

All code removal \o/ ! LGTM.

Tomi
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: