Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify

Subject: Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify

Date: Wed, 18 Mar 2020 21:57:15 +0200

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Tomi Ollila


On Wed, Mar 18 2020, Daniel Kahn Gillmor wrote:

> GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they
> are different enumerated types.  So in C, this is a cosmetic change,
> but it is technically correct if we only had stricter typing.

Change consistent with '@@ node_verify', LGTM.

Tomi

>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  mime-node.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mime-node.c b/mime-node.c
> index d4996a33..e531078c 100644
> --- a/mime-node.c
> +++ b/mime-node.c
> @@ -201,7 +201,7 @@ node_verify (mime_node_t *node, GMimeObject *part)
>  
>      node->verify_attempted = true;
>      node->sig_list = g_mime_multipart_signed_verify (
> -	GMIME_MULTIPART_SIGNED (part), GMIME_ENCRYPT_NONE, &err);
> +	GMIME_MULTIPART_SIGNED (part), GMIME_VERIFY_NONE, &err);
>  
>      if (node->sig_list)
>  	set_signature_list_destructor (node);
> -- 
> 2.25.1
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: