On Tue, Nov 02 2021, David Bremner wrote: > Floris Bruynooghe <flub@devork.be> writes: > >> On Sat 30 Oct 2021 at 13:22 -0300, David Bremner wrote: >>> + >>> + .. deprecated:: 0.35 >>> + Use the ``cfg_path`` parameter instead. >> >> Do you mean the ``config`` parameter to :meth:`__init__` or >> :meth:`__create__` here instead of ``cfg_path``? >> > > Good catch, that is indeed what I meant. > > > [rest of patch snipped] > >> LGTM I think. >> >> As an aside, what is the oldest python version we still want to support? >> I'm wondering if we can get rid of this `if not hasattr(os, 'PathLike')` >> construct which only exists because of python 3.5. > > I usually go by what is in Debian oldstable, which is 3.7.x at this > point. But maybe Tomi wants to comment, he is usually expert at finding > old distros to run notmuch on ;) I run nmbug using python 2.7 >;D Last time I recall python 3.6 is the oldest supported version (i.e. python 3.5 is EOL'd). > > d > > PS: I took the liberty of replying to the list, hope that's OK. Tomi Remembered this after spending some time creating svg image -- so backupping it too :D ⠠⢄⣀⡀⠀⢾⡷ ⢀⣠⣣⣉⠙⢺⡗⠦⢤⣀⡀ ⠸⣌⣋⡼⠀⣸⡇⠀⠀⡜⡌⠁ ⠀⠀⠀⠀⠀⣿⣷⠀⠺⠶⠾⠂ ⠀⠀⠀⠀⠀⣿⣿ ⠀⠀⣠⣴⣶⣿⣿⣶⣦⣄ _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org