Re: [PATCH] emacs: change default for notmuch-crypto-process-mime to t

Subject: Re: [PATCH] emacs: change default for notmuch-crypto-process-mime to t

Date: Mon, 10 Jul 2017 13:24:55 +0300

To: David Bremner, notmuch@freelists.org, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Jul 09 2017, David Bremner wrote:

> There are some cases like remote usage where this might cause
> problems, but those users can easily customize the variable. The
> inconvenience seems to be outweighed by the security benefit for most
> users.
> ---

Trivial enough to LGTM codewise -- too little crypto usage for me to
comment on functionality (other that stronger crypto by default FTW)

Tomi



>  emacs/notmuch-crypto.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
> index 0af727ef..fc2b5301 100644
> --- a/emacs/notmuch-crypto.el
> +++ b/emacs/notmuch-crypto.el
> @@ -24,7 +24,7 @@
>  (require 'epg)
>  (require 'notmuch-lib)
>  
> -(defcustom notmuch-crypto-process-mime nil
> +(defcustom notmuch-crypto-process-mime t
>    "Should cryptographic MIME parts be processed?
>  
>  If this variable is non-nil signatures in multipart/signed
> @@ -40,6 +40,7 @@ providing a prefix when viewing a signed or encrypted message, or
>  by providing a prefix when reloading the message in notmuch-show
>  mode."
>    :type 'boolean
> +  :package-version '(notmuch . "0.25")
>    :group 'notmuch-crypto)
>  
>  (defface notmuch-crypto-part-header
> -- 
> 2.13.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Thread: