Re: [PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

Subject: Re: [PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

Date: Wed, 07 Nov 2012 18:03:36 +0200

To: notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Thu, Oct 04 2012, Tomi Ollila wrote:

> In case text/calendar content contained "folded" data (i.e. line
> continues to next line which begins with whitespace...
>
> or
>
> The text/calendar content is inside separate (application/octet-stream)
> content and the text/calendar entry there contains carriage returns...
>
> ... The parsing of text/calendar content failed so badly that in
> addition to just not showing the calendar content the rest of content
> handling of the thread aborted.
>
> In this change the input calendar content is unfolded extending the
> unfolding code used in `icalendar--get-unfolded-buffer` with single CRs
> removal.
> ---

I wrote comments on this patch but apparently I did not save my buffer
before git-send-email'ing it -- so here are the comments:


This obsoletes id:1349333712-18347-1-git-send-email-tomi.ollila@iki.fi
Commit message is changed to reflect change in pushed patch 
id:1350826509-12119-1-git-send-email-tomi.ollila@iki.fi
also, '\\r?' part in regexp was removed.

Note the difference how id:87d31artti.fsf@inf-8657.int-evry.fr
is inserted before and after this change.


Tomi

Thread: