Re: [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread

Subject: Re: [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread

Date: Sun, 02 Jun 2013 15:35:45 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Jun 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously pick removed the unread tag from its tag display: since the
> tag change is now customisable use the customised variable.
>
> This only affected the tags displayed, not the tags in the database as
> notmuch-show (in the view pane) did the actual tag changes.
> ---
>
> Thanks to Tomi for pointing this out in
> id:m2r4mecofa.fsf@guru.guru-group.fi

LGTM :D

Tomi

>
> Best wishes
>
> Mark
>
>  contrib/notmuch-pick/notmuch-pick.el |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 128fabf..9079acf 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -384,7 +384,8 @@ Does NOT change the database."
>  	(with-current-buffer buffer
>  	  (setq notmuch-pick-message-window window)
>  	  (add-hook 'kill-buffer-hook 'notmuch-pick-message-window-kill-hook)))
> -      (notmuch-pick-tag-update-display (list "-unread"))
> +      (when notmuch-show-mark-read-tags
> +	(notmuch-pick-tag-update-display notmuch-show-mark-read-tags))
>        (setq notmuch-pick-message-buffer buffer))))
>  
>  (defun notmuch-pick-show-message-out ()
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: