Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test

Subject: Re: [PATCH 1/2] test: fix whitespace/indentation in symbol-test

Date: Sun, 06 Sep 2015 12:23:57 +0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Fri, Sep 04 2015, Jani Nikula <jani@nikula.org> wrote:

> Not of much consequence, but makes it nicer to do further edits.
> ---

These 2 patches LGTM ! +1! :D

>  test/symbol-test.cc | 34 ++++++++++++++++++----------------
>  1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/test/symbol-test.cc b/test/symbol-test.cc
> index fb77b418a1a8..77dbc1af44b2 100644
> --- a/test/symbol-test.cc
> +++ b/test/symbol-test.cc
> @@ -3,23 +3,25 @@
>  #include <xapian.h>
>  #include <notmuch.h>
>  
> +int main (int argc, char** argv)
> +{
> +    notmuch_database_t *notmuch;
> +    char *message = NULL;
>  
> -int main(int argc, char** argv) {
> -  notmuch_database_t *notmuch;
> -  char *message = NULL;
> +    if (notmuch_database_open_verbose (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY,
> +				       &notmuch, &message)) {
> +	if (message) {
> +	    fputs (message, stderr);
> +	    free (message);
> +	}
> +    }
>  
> -  if (notmuch_database_open_verbose  (argv[1], NOTMUCH_DATABASE_MODE_READ_ONLY, &notmuch, &message))
> -      if (message) {
> -	  fputs (message, stderr);
> -	  free (message);
> -      }
> +    try {
> +	(void) new Xapian::WritableDatabase (argv[2], Xapian::DB_OPEN);
> +    } catch (const Xapian::Error &error) {
> +	printf("caught %s\n", error.get_msg().c_str());
> +	return 0;
> +    }
>  
> -  try {
> -    (void) new Xapian::WritableDatabase(argv[2], Xapian::DB_OPEN);
> -  } catch (const Xapian::Error &error) {
> -    printf("caught %s\n", error.get_msg().c_str());
> -    return 0;
> -  }
> -
> -  return 1;
> +    return 1;
>  }
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: