On Sun, Apr 15 2012, Mark Walters wrote: > On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote: >> When using the spacebar to scroll through a thread, hitting 'space' >> when the bottom of the last message is visible should take the cursor >> to the end of the buffer rather than immediately archiving the thread >> and moving to the next thread. > > Hi > > This patch looks good to me; (but if people prefer the current behaviour then > can we mark this notmuch::wontfix so it leaves the review queue) I would definitely like to see this patch applied. Less surprising as there is no indication we have reached the bottom of the buffer. > Best wishes > > Mark Tomi > >> --- >> emacs/notmuch-show.el | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el >> index ec72ff8..3f54de0 100644 >> --- a/emacs/notmuch-show.el >> +++ b/emacs/notmuch-show.el >> @@ -1319,6 +1319,11 @@ current window), advance to the next open message." >> ;; This is not the last message - move to the next visible one. >> (notmuch-show-next-open-message)) >> >> + ((not (= (point) (point-max))) >> + ;; This is the last message, but the cursor is not at the end of >> + ;; the buffer. Move it there. >> + (goto-char (point-max))) >> + >> (t >> ;; This is the last message - change the return value >> (setq ret t))) >> -- >> 1.7.8.3 >> >> _______________________________________________ >> notmuch mailing list >> notmuch@notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch