On Mon, Oct 29 2012, Mark Walters wrote:

> The test should be run using the wrapper test-wrapper.sh.  This links
> the tests into the normal notmuch TEST_DIRECTORY and runs them from
> there. After the test is complete then the links are removed.
> ---

Looks pretty good. The emacs-pick has leading spaces and tabs mixed;
you could run whitespace-cleanup on it.

I got a bit irritated to your test-wrapper.sh so I experimented what
could be done to make it a bit more robust. Look at the attachment
for suggestions (i.e. use and reformat parts of it freely).

Tomi

>
> Here are some tests for notmuch-pick. I would have liked to include
> the test structure and run them from inside the pick contrib directory
> but I couldn't get all the paths to work.
>
> Hence, this slightly hacky solution of linking the relevant stuff (one
> test script and one expected output directory) into the normal notmuch
> test directory and running from there.                     
>
> Best wishes
>
> Mark
>
>  contrib/notmuch-pick/README                        |    5 +
>  contrib/notmuch-pick/test-wrapper.sh               |   16 +++
>  contrib/notmuch-pick/test/emacs-pick               |  104 ++++++++++++++++++++
>  .../notmuch-pick-single-thread                     |    6 +
>  .../pick.expected-output/notmuch-pick-tag-inbox    |   53 ++++++++++
>  5 files changed, 184 insertions(+), 0 deletions(-)
>  create mode 100755 contrib/notmuch-pick/test-wrapper.sh
>  create mode 100755 contrib/notmuch-pick/test/emacs-pick
>  create mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-single-thread
>  create mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox