Re: [PATCH] test: move nonexistant directory to something under notmuch's control.

Subject: Re: [PATCH] test: move nonexistant directory to something under notmuch's control.

Date: Tue, 07 Apr 2015 15:30:20 +0300

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Tue, Apr 07 2015, David Bremner <david@tethera.net> wrote:

> Apparently some systems actually have a directory called /nonexistent.
> It's hard to fathom a good reason for that, but oh well. As long as we
> don't create such a directory inside the notmuch source tree, the new
> version should be more robust.

2 things

although it makes this diff bigger should all /nonexistent... paths be
changed to ./nonexistent... -- it is a bit confusing having just this one
(or should there be another patch which converts rest of those)

Is 'nonexistant' there for a reason (as dictionaries find definitions for
that) or is it misspelling of 'nonexistent'. If there is no reason I'd like
to see it written 'nonexistent' uniformly :D


Tomi


> ---
> This should (hopefully) fix the current failures on travis
>  test/T560-lib-error.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh
> index 828a44b..57abb28 100755
> --- a/test/T560-lib-error.sh
> +++ b/test/T560-lib-error.sh
> @@ -43,13 +43,13 @@ int main (int argc, char** argv)
>  {
>      notmuch_database_t *db;
>      notmuch_status_t stat;
> -    stat = notmuch_database_open ("/nonexistent/foo", 0, 0);
> +    stat = notmuch_database_open ("./nonexistent/foo", 0, 0);
>  }
>  EOF
>  cat <<'EOF' >EXPECTED
>  == stdout ==
>  == stderr ==
> -Error opening database at /nonexistent/foo/.notmuch: No such file or directory
> +Error opening database at ./nonexistent/foo/.notmuch: No such file or directory
>  EOF
>  test_expect_equal_file EXPECTED OUTPUT
>  
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: