Re: [PATCH] go: use a different goconfig package

Subject: Re: [PATCH] go: use a different goconfig package

Date: Wed, 24 Apr 2013 12:30:43 +0300

To: David Bremner, Justus Winter, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Wed, Apr 24 2013, David Bremner <david@tethera.net> wrote:

> Justus Winter <4winter@informatik.uni-hamburg.de> writes:
>
>> The notmuch-addrlookup utility uses a third party library to read the
>> notmuch configuration file. The previously used implementation at
>> "github.com/kless/goconfig" vanished, so this patch switches to the
>> implementation at "github.com/msbranco/goconfig". As the
>> implementations differ at the API level, the code is updated
>> accordingly.
>
> It's great that you fixed this, but the whole idea of something failing
> to build depending on the status of a website makes me pretty
> uncomfortable.

Me too, but this is the status quo (atm(*)). The patch looks good
and state of things tolerable to me.

(*) and probably things won't change in (near) future ;/

> d

Tomi

Thread: