Re: [PATCH 1/3] database: Add notmuch_database_compact_close

Subject:Re: [PATCH 1/3] database: Add notmuch_database_compact_close

Date:Sun, 20 Oct 2013 20:02:05 +0300

To:Ben Gamari ,notmuch@notmuchmail.org

Cc:

From:Tomi Ollila


On Thu, Oct 10 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:

>
> another, small change:
>
>       case "${xapian_version}" in
> -         0.*|1.[01].*|1.2.[0-5])
> +         0.*|1.[01].*|1.2.[0-5]|1.2.[0-5][^0-9]*)
>               printf "No (only available with Xapian > 1.2.6).\n" ;;

Forget the above suggestion, as mentioned below this would not work in
dash. I presume attempting to compile compaction support will fail in 
case such support is not there. If we ever encounter such a bug report
let's revisit this then...

> someone might do version like 1.2.4-abc but probably not 1.2.04 (nor 1.2a.4)
>
> (side note: case $x in [^...]) works with bash (and ksh&zsh, but not with dash)

Tomi

Thread: