Re: [PATCH] cli/help: give a hint about notmuch-emacs-mua

Subject: Re: [PATCH] cli/help: give a hint about notmuch-emacs-mua

Date: Sun, 03 Dec 2017 15:26:32 +0200

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Tomi Ollila


On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote:

> On Thu 2017-11-30 11:08:05 +0200, Tomi Ollila wrote:
>> On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote:
>>
>>> On Thu 2017-10-26 18:27:51 -0400, Daniel Kahn Gillmor wrote:
>>>> "notmuch help" doesn't mention "notmuch-emacs-mua" even though we
>>>> support it through the try_external_command() mechanism.
>>>>
>>>> In addition, "notmuch help emacs-mua" doesn't work, even though we
>>>> ship the appropriate manpage.
>>>>
>>>> This changeset fixes both of these problems.
>>>
>>> Ping!  i don't think this patch is complex or objectionable.  Can it be
>>> merged?
>>
>> it may (*) look like we don't have #if WITH_EMACS (**) cpp macros defined ???
>>
>> Tomi
>>
>> (*) did not check...
>>
>> (**) this is emacs-specific stull, less generic that other hints (if that
>> matters) ...
>>
>> Sorry to cause confusion...
>
> confusion is right!  i don't understand what you're saying, sorry.  are
> you suggesting a different change somehow?  Want to propose a different
> patch?

My thought was that even though user may compile notmuch without emacs
support (and notmuch-emacs-mua not installed) we would be hinting 
`notmuch emacs-mua` command to exist.

Tomi

>
>            --dkg
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: