Re: [PATCH 2/2] lib: use a stricter unused macro

Subject: Re: [PATCH 2/2] lib: use a stricter unused macro

Date: Mon, 15 Feb 2021 22:22:25 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc: David Bremner

From: Tomi Ollila

On Sun, Feb 14 2021, David Bremner wrote:

> This would have caught bugs like the one corrected in the previous
> commit.

Series LGTM.

Tomi

> ---
>  lib/notmuch-private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
> index 2fbf7ab9..2f5ccd6a 100644
> --- a/lib/notmuch-private.h
> +++ b/lib/notmuch-private.h
> @@ -76,7 +76,7 @@ NOTMUCH_BEGIN_DECLS
>  #define NOTMUCH_CLEAR_BIT(valp,  bit) \
>      (_NOTMUCH_VALID_BIT (bit) ? (*(valp) &= ~(1ull << (bit))) : *(valp))
>  
> -#define unused(x) x __attribute__ ((unused))
> +#define unused(x) x ## _unused __attribute__ ((unused))

looks familiar ;D

>  
>  /* Thanks to Andrew Tridgell's (SAMBA's) talloc for this definition of
>   * unlikely. The talloc source code comes to us via the GNU LGPL v. 3.
> -- 
> 2.30.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: