On Sat, Oct 20 2012, Ethan Glasser-Camp wrote: > Daniel Bergey <bergey@alum.mit.edu> writes: > >> From a show buffer, bbdb/notmuch-snarf-from imports the sender into >> bbdb. bbdb/notmuch-snarf-to attempts to import all recipients. BBDB >> displays a buffer with each contact; C-g displays the next contact, or >> returns to the notmuch-show buffer. >> >> This is my first notmuch patch. Comments very welcome. > > Hi! > >> emacs/notmuch-show.el | 28 ++++++++++++++++++++++++++++ > > I don't think this belongs in notmuch-show. My first inclination is that > this should go into a new file contrib/notmuch-bbdb.el (assuming there's > no other notmuch-bbdb integration stuff floating around). > >> 1 file changed, 28 insertions(+) >> >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el >> index 6335d45..3bc1da0 100644 >> --- a/emacs/notmuch-show.el >> +++ b/emacs/notmuch-show.el >> @@ -1895,6 +1895,34 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')." >> (button-get button :notmuch-filename) >> (button-get button :notmuch-content-type))))))) >> >> +;; bbdb interaction functions, awaiting user keybindings >> + >> +(defun bbdb/snarf-between-commas () >> + ; What about names written "Surname, First M" <user@server.tld>? > > Most comments in emacslisp start with two semicolons. 3 quick comments. I was thinking notmuch-bbdb.el but contrib/notmuch-bbdb.el could be good start. then functions like notmuch-bbdb/snarf-between-commas etc... and yes, ;; comments -- that also keeps indent-region happy. Tomi