Re: [PATCH] test: add test for syntax of emacs test library

Subject: Re: [PATCH] test: add test for syntax of emacs test library

Date: Sun, 12 Jan 2014 11:56:41 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sun, Jan 12 2014, David Bremner <david@tethera.net> wrote:

> If there is a syntax error in the emacs test library, it causes other
> tests to hang or crash without a useful error message.
>
> This test could be eliminated if the error reporting for emacs tests
> was somehow improved.
> ---

This helps developers to deal with some mysteries in the test suite so LGTM.

Tomi


>  test/emacs | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/test/emacs b/test/emacs
> index 863219d..7dc9a8e 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -7,6 +7,10 @@ EXPECTED=$TEST_DIRECTORY/emacs.expected-output
>  
>  add_email_corpus
>  
> +# syntax errors in test-lib.el cause mysterious failures
> +test_expect_success 'Syntax of emacs test library' \
> +    "${TEST_EMACS} -Q --batch --load $TEST_DIRECTORY/test-lib.el"
> +
>  test_begin_subtest "Basic notmuch-hello view in emacs"
>  test_emacs '(notmuch-hello)
>  	    (test-output)'
> -- 
> 1.8.5.2

Thread: