Re: [PATCH v2] cli/new: add more debugging output

Subject: Re: [PATCH v2] cli/new: add more debugging output

Date: Sun, 02 Aug 2015 12:18:22 +0300

To: David Bremner

Cc: notmuch@notmuchmail.org

From: Tomi Ollila


On Sun, Aug 02 2015, David Bremner <david@tethera.net> wrote:

> Try to narrow down what part of the code adds files and directories to
> the queue(s) to be deleted.
> ---

Looks trivial enough to me. +1

Tomi


>
>  - print slightly less scary messages
>  - use git-send-email to send
>
>  notmuch-new.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/notmuch-new.c b/notmuch-new.c
> index 8ff1ade..ee786a3 100644
> --- a/notmuch-new.c
> +++ b/notmuch-new.c
> @@ -528,6 +528,10 @@ add_files (notmuch_database_t *notmuch,
>  					      "%s/%s", path,
>  					      notmuch_filenames_get (db_files));
>  
> +	    if (state->debug)
> +		printf ("(D) add_files_recursive, pass 2: queuing passed file %s for deletion from database\n",
> +			absolute);
> +
>  	    _filename_list_add (state->removed_files, absolute);
>  
>  	    notmuch_filenames_move_to_next (db_files);
> @@ -542,6 +546,9 @@ add_files (notmuch_database_t *notmuch,
>  	    {
>  		char *absolute = talloc_asprintf (state->removed_directories,
>  						  "%s/%s", path, filename);
> +		if (state->debug)
> +		    printf ("(D) add_files_recursive, pass 2: queuing passed directory %s for deletion from database\n",
> +			absolute);
>  
>  		_filename_list_add (state->removed_directories, absolute);
>  	    }
> @@ -610,6 +617,9 @@ add_files (notmuch_database_t *notmuch,
>  	char *absolute = talloc_asprintf (state->removed_files,
>  					  "%s/%s", path,
>  					  notmuch_filenames_get (db_files));
> +	if (state->debug)
> +	    printf ("(D) add_files_recursive, pass 3: queuing leftover file %s for deletion from database\n",
> +		    absolute);
>  
>  	_filename_list_add (state->removed_files, absolute);
>  
> @@ -622,6 +632,10 @@ add_files (notmuch_database_t *notmuch,
>  					  "%s/%s", path,
>  					  notmuch_filenames_get (db_subdirs));
>  
> +	if (state->debug)
> +	    printf ("(D) add_files_recursive, pass 3: queuing leftover directory %s for deletion from database\n",
> +		    absolute);
> +
>  	_filename_list_add (state->removed_directories, absolute);
>  
>  	notmuch_filenames_move_to_next (db_subdirs);
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: