Re: V2 of directory delete patches

Subject: Re: V2 of directory delete patches

Date: Sun, 11 Oct 2015 19:45:56 +0300

To: David Bremner, Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sat, Oct 10 2015, David Bremner <david@tethera.net> wrote:

> Changes since id:cover.1443213654.git.jani@nikula.org
>
>   - tidy commit messages
>   - update docs in lib/notmuch.h
>   - make an executive decision not to push _remove_directory into lib
>   for now; it can always be a new api layer later.
>   - unmark fixed tests
>   - wrap xapian calls in try/catch


Looks good to me. tests pass.

Tomi

• Previous message (by thread): Re: V2 of directory delete patches

Thread:

• Jani Nikula—[PATCH 0/3] delete directory documents on directory removal [inbox, unread]
  • Jani Nikula—[PATCH 1/3] test: flag one more notmuch new test as broken [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH 2/3] lib: add interface to delete directory documents [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 2/3] lib: add interface to delete directory documents [inbox, unread]
  • Jani Nikula—[PATCH 3/3] cli: delete directory documents on directory removal [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—V2 of directory delete patches [inbox, unread]
      • David Bremner—[PATCH 1/3] test: flag one more notmuch new test as broken [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 2/3] lib: add interface to delete directory documents [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—[PATCH 3/3] cli: delete directory documents on directory removal [inbox, notmuch::patch, notmuch::pushed, unread]
      • Tomi Ollila—Re: V2 of directory delete patches [inbox, unread]
        • David Bremner—Re: V2 of directory delete patches [inbox, unread]