Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands

Subject: Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands

Date: Sat, 11 Jan 2014 12:22:52 +0200

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Fri, Jan 10 2014, Jani Nikula <jani@nikula.org> wrote:

> Apart from the status codes for format mismatches, the non-zero exit
> status codes have been arbitrary. Make the cli consistently return
> either EXIT_SUCCESS or EXIT_FAILURE.
> ---

These 2 patches LGTM.

Tomi


>  notmuch-compact.c |  6 +++---
>  notmuch-config.c  | 23 ++++++++++++++---------
>  notmuch-count.c   | 16 +++++++---------
>  notmuch-dump.c    | 21 +++++++++------------
>  notmuch-insert.c  | 25 +++++++++++--------------
>  notmuch-new.c     | 18 ++++++++----------
>  notmuch-reply.c   | 20 +++++++++-----------
>  notmuch-restore.c | 23 +++++++++--------------
>  notmuch-search.c  | 18 ++++++++----------
>  notmuch-setup.c   | 15 +++++++--------
>  notmuch-show.c    | 18 ++++++++----------
>  notmuch-tag.c     | 22 +++++++++++-----------
>  notmuch.c         | 43 ++++++++++++++++++++++++++++---------------

Thread: