Fwd: [PATCH] Fix saved-search buffer titles

Subject: Fwd: [PATCH] Fix saved-search buffer titles

Date: Thu, 20 Jun 2024 14:29:10 +0200

To: notmuch@notmuchmail.org

Cc:

From: Rudolf Adamkovič


Ping.

-------------------- Start of forwarded message --------------------
From: Rudolf Adamkovič <salutis@me.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] Fix saved-search buffer titles
Date: Thu, 14 Dec 2023 23:50:14 +0100

Fellow hackers,

So, I have always wondered why Notmuch uses the strangest buffer titles
ever, and yesterday I decided to take a look under the hood...  I found
that the code in 'notmuch-search-buffer-title' defines and uses a pair
of variables, named 'longest' and 'longest-length', but never sets the
latter, which causes the strange buffer titles I observe.  Please see
the attached patch with a fix.

P.S. I could not make the test suite work, not in the time I had for the
fix, so ... see the test in the commit message. :)

Rudy
-- 
"The introduction of suitable abstractions is our only mental aid to
organize and master complexity."
--- Edsger Wybe Dijkstra, 1930-2002

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia
-------------------- End of forwarded message --------------------

-- 
"I do not fear death.  I had been dead for billions and billions of years
before I was born, and had not suffered the slightest inconvenience from it."
--- Mark Twain, paraphrased

Rudolf Adamkovič <rudolf@adamkovic.org> [he/him]
http://adamkovic.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: