On Sun, Aug 16 2020, David Bremner wrote: > This is quite fragile, but it works for now, unlike the python > version. > > In general it seems conf.py is not intended to be evaluated outside of > sphinx, as it assumes certain global names (in particular "tags") are > defined. > --- > > I am going to apply this to unblock the release process, but I > welcome better solutions. for this case solution is good enough... > > devel/release-checks.sh | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/devel/release-checks.sh b/devel/release-checks.sh > index 7ba94822..cfa208d5 100755 > --- a/devel/release-checks.sh > +++ b/devel/release-checks.sh > @@ -178,10 +178,7 @@ esac > year=`exec date +%Y` > echo -n "Checking that copyright in documentation contains 2009-$year... " > # Read the value of variable `copyright' defined in 'doc/conf.py'. > -# As __file__ is not defined when python command is given from command line, > -# it is defined before contents of 'doc/conf.py' (which dereferences __file__) > -# is executed. > -copyrightline=`exec python -c "with open('doc/conf.py') as cf: __file__ = ''; exec(cf.read()); print(copyright)"` > +copyrightline=$(grep ^copyright doc/conf.py) For consistency and to save one fork(2) $(exec grep ...), but I could live with this, too ;D So LGTM. Tomi (2) bash forks for subshell and then for grep, even in this trivial case. Other shells fork only once. > case $copyrightline in > *2009-$year*) > echo Yes. ;; > -- > 2.28.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org