Re: [PATCH 0/5] Use closures and other emacs cleanup

Subject: Re: [PATCH 0/5] Use closures and other emacs cleanup

Date: Fri, 23 Jul 2021 23:18:11 +0300

To: Jonas Bernoulli, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Mon, Jul 19 2021, Jonas Bernoulli wrote:

> Some assorted emacs cleanup and fixes.  The big one is the switch to
> using closures instead of backquoted lambdas.  The other commits for
> the most part just deal with things the compiler complained about.
>
> Jonas Bernoulli (5):
>   emacs: use closures instead of backquoted lambdas
>   emacs: add some function declarations
>   emacs: fix some option type declarations
>   emacs: notmuch-show-pipe-message: cosmetics
>   emacs: shorten lines in two doc-strings

This series *looks* good to me (especially the 1st change -- I hope it
works >;D). I don't understand why byte compiler would complain
about too long lines but perhaps the changed docstrings are better
(2 weeks in island w/o exposion to english language so can say notmuch
about the content (if i could otherwise >;)))

Tomi

>
>  emacs/notmuch-draft.el |  2 +-
>  emacs/notmuch-hello.el | 24 ++++++++-------
>  emacs/notmuch-jump.el  | 30 +++++++++++--------
>  emacs/notmuch-show.el  | 26 ++++++++---------
>  emacs/notmuch-tag.el   |  2 +-
>  emacs/notmuch-tree.el  | 66 +++++++++++++++++++++++++-----------------
>  emacs/notmuch.el       | 13 +++++----
>  7 files changed, 93 insertions(+), 70 deletions(-)
>
> -- 
> 2.31.1
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: