On Fri, Apr 24 2020, David Bremner wrote: > Milton Vandersloot <miltonrobertvandersloot1412@protonmail.com> writes: >> >> [PATCH] Let test_emacs_expect_t respect missing external prerequisites >> >> test_emacs_expect_t did not test for missing prerequisites (even though >> it called test_emacs which does it). Fix that by testing for missing >> prerequisites. >> > > I agree there's a bug here, but I'm not sure this is the best/cleanest > fix. Maybe Tomi (in Cc) can comment. The logic for prerequisite checking > is already opaque. For example test_skip is already calling > test_check_missing_external_prereqs_ as a side effect. For starters I > wonder if test_emacs should use a return value to indicate failure, > along the lines of the patch at the end of the message. I'd like David's approach, but in that case we don't get the "missing prerequisities" messages. Milton's solution looks like something that works =D. Just that the content inside {} needs to be indented, and opening brace ({) should be after || in same line... In case of test_skip it doesn't know about missing emacs prerequisities as the "subtest prerequisities" infomation is cleaned before every test and the information is regained in test_emacs... Tomi > BTW, it will make our life easier if you follow > https://notmuchmail.org/contributing/#index5h2; in particular using > git-send-email and keeping the discussion/notes after ---. > _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch