Re: [PATCH] Added C-up and C-down to cycle through previous searches

Subject: Re: [PATCH] Added C-up and C-down to cycle through previous searches

Date: Sun, 05 Jun 2011 09:25:44 +0200

To: Dmitry Kurochkin, notmuch@dima.secretsauce.net, notmuch@notmuchmail.org

Cc:

From: Xavier Maillard

Hi,

On Sun, 29 May 2011 20:04:00 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Dima.
> 
> On Sun, 29 May 2011 01:56:28 -0700, notmuch@dima.secretsauce.net wrote:
> > From: Dima Kogan <dima@secretsauce.net>
> > 
> > ---
> > 
> >  Hi.
> > 
> >  I made a few improvements to the emacs UI. This patch allows the user to scroll
> >  through the most recent searches with C-up and C-down while in the search box.
> > 
> 
> This sounds like a very nice improvement to me!  I just have one
> concern: Why C-up and C-down?  I believe M-p and M-n would be more
> natural for Emacs users (at least for me :)).

+1. M-p/M-n is way simpler to remember for me too. IMO, that should be
setq'able at the user level to suit best users preferences.

/Xavier

Thread: