Re: [PATCH] lib: remove notmuch_query_{count, search}_{threads, messages}

Subject: Re: [PATCH] lib: remove notmuch_query_{count, search}_{threads, messages}

Date: Sun, 26 Feb 2017 11:07:38 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sat, Feb 25 2017, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>
>> On Wed, 22 Feb 2017, David Bremner <david@tethera.net> wrote:
>>> These 4 functions were originally deprecated in notmuch 0.21, more
>>> than a year ago.
>>
>> This leaves the implementations of the functions as unused code behind.

I thought this was intentional as there were no LIBNOTMUCH_*_VERSION bump.

>
> oh oops.
>
>> How long until we can add them back with the same signature as the _st
>> versions, and deprecate the _st versions instead? ;)
>>
>
> I was thinking at least one release ;).

So, for 0.25 the non _st versions are back, _st versions as wrapper (or
some linking-time aliases?/?) for the non_st and n-year deprecation period
for the _st version (to not piss developers using the API again ;) ?

>
> d

Tomi

Thread: