Re: [PATCH v3] emacs: Avoid recentering window when building imenu in notmuch-show

Subject: Re: [PATCH v3] emacs: Avoid recentering window when building imenu in notmuch-show

Date: Sun, 16 Feb 2025 22:25:53 +0100

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Damien Cassou


Hi Tomi,

Tomi Ollila <tomi.ollila@iki.fi> writes:
> Maeby too detailed story this time, could have conveyed the intention
> with less words (but the intention, is clear, at least) :D


I completely rewrote it. It's not shorter but it is more focused in my
opinion. I couldn't make it shorter.

> Anyway, the behavior does not differ just in not doing that 
> (notmuch-show-message-adjust), so explaining if (not) there is difference
> in interactive behavior would be nice. We could tolerate the current
> commit message if it is close enough of the final understanding of
> this change. 


I agree. The new commit message tries to explain why the new
implementation isn't just inlining notmuch-show-previous-message without
the recentering. I hope it is clearer.

Message-ID: <20250216212223.37905-1-damien@cassou.me>

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: