Re: [PATCH 2/3] emacs: use a single history for all searches

Subject: Re: [PATCH 2/3] emacs: use a single history for all searches

Date: Wed, 18 Jan 2012 18:18:48 +0000

To: Dmitry Kurochkin

Cc: notmuch

From: David Edmondson

On Wed, 18 Jan 2012 21:57:27 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > The test output updates included here should be with the previous patch,
> > shouldn't they?
> 
> Indeed.  Would send v2.

That's not necessary for me.

> > Should user-typed queries be trimmed?
> 
> IMO that would not hurt.  But we need to do it before it gets added to
> the history.  And that may be tricky.  So this patch does trimming only
> for queries from notmuch-hello search box (as it was before).

Okay.

• Previous message (by thread): Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

Thread:

• Dmitry Kurochkin—[PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Dmitry Kurochkin—[PATCH 2/3] emacs: use a single history for all searches [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—Re: [PATCH 2/3] emacs: use a single history for all searches [inbox, signed, unread]
      • Dmitry Kurochkin—Re: [PATCH 2/3] emacs: use a single history for all searches [inbox, unread]
        • David Edmondson—Re: [PATCH 2/3] emacs: use a single history for all searches [inbox, signed, unread]
  • Dmitry Kurochkin—[PATCH 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—Re: [PATCH 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer [inbox, signed, unread]
  • Jani Nikula—Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, unread]
    • Dmitry Kurochkin—Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, unread]
    • Pieter Praet—Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, unread]
      • Jani Nikula—Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, unread]
  • David Edmondson—Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, signed, unread]
  • Dmitry Kurochkin—[PATCH v2 0/3] emacs: notmuch-hello search cleanup [inbox, unread]
    • Dmitry Kurochkin—[PATCH v2 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, notmuch::emacs, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
    • Dmitry Kurochkin—[PATCH v2 2/3] emacs: use a single history for all searches [inbox, notmuch::emacs, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
    • Dmitry Kurochkin—[PATCH v2 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer [inbox, notmuch::emacs, notmuch::moreinfo, notmuch::patch, notmuch::stale, unread]
    • David Edmondson—Re: [PATCH v2 0/3] emacs: notmuch-hello search cleanup [inbox, notmuch::review, signed, unread]
    • Dmitry Kurochkin—[PATCH v3 0/3] emacs: notmuch-hello search cleanup [inbox, unread]
      • Dmitry Kurochkin—[PATCH v3 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Dmitry Kurochkin—[PATCH v3 2/3] emacs: use a single history for all searches [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Dmitry Kurochkin—[PATCH v3 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Edmondson—Re: [PATCH v3 0/3] emacs: notmuch-hello search cleanup [inbox, notmuch::review, signed, unread]
      • Austin Clements—Re: [PATCH v3 0/3] emacs: notmuch-hello search cleanup [inbox, notmuch::review, unread]
      • Dmitry Kurochkin—[PATCH v4 0/3] emacs: notmuch-hello search cleanup [inbox, unread]
        • Dmitry Kurochkin—[PATCH v4 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—Re: [PATCH v4 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer [inbox, unread]
        • Dmitry Kurochkin—[PATCH v4 2/3] emacs: use a single history for all searches [inbox, notmuch::patch, notmuch::pushed, unread]
        • Dmitry Kurochkin—[PATCH v4 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer [inbox, notmuch::patch, notmuch::pushed, unread]