Re: [PATCH v4 11/11] emacs: show: recognize the exclude flag.

Subject: Re: [PATCH v4 11/11] emacs: show: recognize the exclude flag.

Date: Fri, 03 Feb 2012 08:15:59 +0000

To: Mark Walters, notmuch@notmuchmail.org, amdragon@MIT.EDU

Cc:

From: David Edmondson

On Thu,  2 Feb 2012 17:43:39 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> +    (when (eq (point) (point-max))

"(when (eobp)" is more usual.

> +      (goto-char (point-min))
> +      (notmuch-show-next-matching-message))

Otherwise the Emacs patch looks good.

• Previous message (by thread): Re: [Patch V4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

Thread:

• Mark Walters—[Patch V4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
  • Mark Walters—[PATCH v4 01/11] cli: add --no-exclude option to count and search. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 02/11] cli: Add --no-exclude to the man pages for search and count [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 03/11] test: add tests for new cli --no-exclude option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 04/11] lib: Rearrange the exclude code in query.cc [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 05/11] lib: Make notmuch_query_search_messages set the exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 06/11] lib: Add the exclude flag to notmuch_query_search_threads [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, notmuch::review, unread]
      • Mark Walters—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, unread]
        • Jani Nikula—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, unread]
          • Mark Walters—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, unread]
            • Jani Nikula—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, notmuch::review, unread]
              • Mark Walters—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, unread]
                • Jani Nikula—Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages [inbox, unread]
  • Mark Walters—[PATCH v4 08/11] cli: Make notmuch-show respect excludes. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH v4 08/11] cli: Make notmuch-show respect excludes. [inbox, notmuch::review, unread]
      • Mark Walters—Re: [PATCH v4 08/11] cli: Make notmuch-show respect excludes. [inbox, unread]
        • Jani Nikula—Re: [PATCH v4 08/11] cli: Make notmuch-show respect excludes. [inbox, unread]
          • Mark Walters—Re: [PATCH v4 08/11] cli: Make notmuch-show respect excludes. [inbox, unread]
  • Mark Walters—[PATCH v4 09/11] test: update tests to reflect the exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 10/11] cli: omit excluded messages in results where appropriate. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Mark Walters—[PATCH v4 11/11] emacs: show: recognize the exclude flag. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—Re: [PATCH v4 11/11] emacs: show: recognize the exclude flag. [inbox, notmuch::review, signed, unread]
  • Mark Walters—Re: [Patch V4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]