Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages

Subject: Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages

Date: Fri, 09 May 2014 15:17:41 +0100

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Fri, May 09 2014, Mark Walters wrote:
> The first two patches are fine, although I think I like constructing a
> query then quoting rather than quoting bits of a query and bolting them
> together (even the both work).

Agreed. I've no idea what I was thinking.

> My concern is that the current approach gives the user no warning if
> they are about to overwrite an existing file, and that this is true
> regardless of any emacs settings. 
>
> Could we do these saves by loading into a temporary buffer and then
> using the normal emacs save buffer functions? That way we get the
> benefit of emacs's normal query-overwrite, and respect any user
> customizations of that.

Yes, that is a better approach.
signature.asc (application/pgp-signature)

Thread: