On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> -1

Which puts me back to 0 :-(

> One particular issue with your patch is that it adds (incorrect) charset
> parameter to plain/text parts which are converted to UTF-8 in JSON
> output.

Patches that break things should obviously not be accepted...

> I already tried to solve the above problem using a more general approach
> (output all content-type parameters, not just charset) [1].  There was a
> lengthy discussion on IRC about it and it was rejected.  The consensus
> was that we need to make some more substantial changes to JSON and raw
> output formats to properly fix the issue (and the issue is more general
> than what this patch fixes, other content-type parameters are useful for
> renderers as well and should be included in the output).

...but a useful point fix should not be blocked by theoretical future
work.

> I am planning to work on a proper fix for this issue, but decided to
> postpone it until Austin's rewrite of notmuch show is complete.

If the UTF8 text/plain part issue can be resolved, would you be happier
to accept this as an interim fix whilst we wait for the more complete
solution?

Nothing in the patch (so far) should make your proposed changes any
harder, so I'm not sure what the problem would be.