Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

Subject: Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

Date: Thu, 22 Dec 2011 15:27:22 +0000

To: Aaron Ecay, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Thu, 22 Dec 2011 09:29:55 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> Would the problem you had with previous-s-c-prop-change be fixed by the
> patch to the original function I sent in the thread starting at
> id:"m2y5u5cykp.fsf@kcals.intra.maillard.im" ?

I think so, yes. Re-writing the new version I posted to use
`previous-single-char-property-value' in the way that you describe:

   ((let ((visible-bottom (notmuch-show-message-bottom)))
      (while (invisible-p visible-bottom)
	(setq visible-bottom (max (point-min)
				  (1- (previous-single-char-property-change
				       visible-bottom 'invisible)))))
      (> visible-bottom (window-end)))
    ;; The end of this message is not visible - scroll.
    (scroll-up)
    nil)

seems to work in quick testing.

I'd vote to integrate your change if it seems correct to everyone else,
then I'll argue for a re-write separately.
part-000.sig (application/pgp-signature)

Thread: