Hi all - I started looking at how to use GMimeMessage for the headers in notmuch reply, based on [1]. Turns out we *already* parse the message twice in most cases, once in the lib and once in mime_node_open(). However, notmuch reply is a mess, and passing that GMIME_MESSAGE (node->part) from the node to add_recipients_from_message() gets tricky. Here's a bunch of refactoring to make the future work easier. I like the diffstat already. Oh, as a bonus, if we ever try to get that "reply to multiple messages at once" feature back, this makes it easier too. BR, Jani. [1] id:87bn30tdb0.fsf@nikula.org Jani Nikula (7): cli/reply: push notmuch reply format abstraction lower in the stack cli/reply: reuse show_reply_headers() in headers-only format cli/reply: unify reply format functions cli/reply: reorganize create_reply_message() cli/reply: make references header creation easier to follow cli/reply: reuse create_reply_message() also for headers-only format cli/reply: reduce the reply format abstractions notmuch-reply.c | 266 +++++++++++++++++--------------------------------------- 1 file changed, 79 insertions(+), 187 deletions(-) -- 2.1.4