On Wed, Apr 18, 2012 at 5:41 PM, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > Felipe Contreras <felipe.contreras@gmail.com> writes: > >> On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin >> <dmitry.kurochkin@gmail.com> wrote: >>> Hi Felipe. >>> >>> Felipe Contreras <felipe.contreras@gmail.com> writes: >>> >>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula <jani@nikula.org> wrote: >>>> >>>>> Running "notmuch compose" more than once within a second would result in >>>>> identical message ids for the messages, which is not a good idea. That's >>>>> not likely in interactive use, but the notmuch cli is highly scriptable, >>>>> so someone is bound to hit this. >>>>> >>>>> Some paranoid might also be worried about "leaking" the time you run >>>>> "notmuch compose"... which may be different from the actual time you >>>>> send the message. >>>> >>>> It's still better than the current situation; nothing. In any case, >>>> people that have not needed this would not be affected; their UI would >>>> override the Message-ID. >>>> >>> >>> I disagree. If notmuch CLI generates a Message-ID, it must be a good >>> one. Otherwise we make users falsely believe that they do have a proper >>> Message-ID while in fact they do not. And that would bite them sooner >>> or later. >> >> And then they'll report it, and we would fix it. >> >> Anyway, everything comes from a patch, so, do you have a patch, >> pseudo-code, or even a suggestion? >> > > A patch needs some positive reviews to be accepted. Replying to > comments with "make a better patch" may not be the best strategy for > getting your patches accepted. I did not say "make a better patch" or anything of the sort. You made comments, I replied to those comments. Your argument is essentially: a) we don't have feature X b) this patch applies feature X imperfectly c) I don't know how to implement X perfectly I don't think "patch is not perfect" is a valid argument. No patch is perfect, if you want a better patch, then *at least* you should suggest what would make it better. Cheers. -- Felipe Contreras