Re: [PATCH 2/2] ruby: enable garbage collection using talloc

Subject: Re: [PATCH 2/2] ruby: enable garbage collection using talloc

Date: Sat, 26 Jun 2021 15:05:10 -0500

To: David Bremner

Cc: notmuch@notmuchmail.org, Tomi Ollila

From: Felipe Contreras


On Sat, Jun 26, 2021 at 2:54 PM David Bremner <david@tethera.net> wrote:
>
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> >>
> >> One issue to double check: in a few places we explicitely _don't_ use
> >> talloc. What happens when those objects are passed to talloc_steal?
> >
> > Seems like talloc aborts. Are there any of such objects?
> >
>
> At least anything where notmuch.h says "allocated by malloc and should be freed
> by the caller".
>
> - all of the error_message output parameters
> - notmuch_database_get_config output parameter 'value'

I meant objects in the context of Ruby objects: Database, Directory,
FileNames, Query, Threds, Thread, Messages, Message, Tags. I think all
of them correspond to a notmuch_*_t that was allocated with talloc.

-- 
Felipe Contreras
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: