Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value

Subject: Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value

Date: Sun, 13 Jan 2013 16:41:28 +0200

To: David Bremner

Cc: Tomi Ollila, Notmuch Mail

From: Jani Nikula


On Jan 13, 2013 4:37 PM, "David Bremner" <david@tethera.net> wrote:
>
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> > In case last input for batch tagging was either invalid or skippable
> > line, notmuch command exited with non-zero value.
> > After this change if there is at least one invalid line, notmuch
> > command will exit with non-zero value. Additionally, skipped lines
> > (last or other) doesn't cause non-zero value to be returned.
>
> This looks OK. In a perfect world we'd have a test for return values.

And distinct codes for warnings and errors... but can't have everything at
once...

J.

> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: