Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

Subject: Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

Date: Thu, 17 Nov 2011 08:21:59 +0200

To: Pieter Praet

Cc: Tomi Ollila, Notmuch Mail

From: Jani Nikula


On Nov 16, 2011 11:39 PM, "Pieter Praet" <pieter@praet.org> wrote:
>
> On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila <tomi.ollila@iki.fi>
wrote:
> > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet <pieter@praet.org>
wrote:
> > > No further explanation needed.
> > > ---
> > >  NEWS |   14 +++++++-------
> > >  1 files changed, 7 insertions(+), 7 deletions(-)
> >
> > The 'No further explanation needed.' should be *BELOW* the waistline
(---) ;);
> > now it goes to the commit message which is probably not what anybody
wants.
> >
>
> That was intended :)
>
> Empty commit messages are frowned upon (even if the commit subject is
> sufficiently descriptive), so "rather a pointless one than none?" :)

Generally I think the message should be self-contained and understandable
without the subject line, so IMHO a full meaningful sentence is better than
one/none, even if it's repetition.

BR,
Jani.

Thread: