T040 fails on Fedora 39 rebuild

Subject: T040 fails on Fedora 39 rebuild

Date: Thu, 20 Jul 2023 20:54:51 +0200

To: notmuch@notmuchmail.org

Cc:

From: Michael J Gruber


Hi there,

funny failures again during the mass rebuild for the (not quite yet)
upcoming Fedora rebuild. This test passed just a few weeks ago, so the
failure is related to something else changing. But still it shows that
the order in which `notmuch config` produces new config can depend on
something else. It looks a bit like a buffering problem, but what do I
know ... In any case, this is with notmuch 0.37, and I did not see any
commit in master which could change that.

I vaguely remember we had g_key_file ordering issues before - maybe in
another project?

The group comment for the next group is written too early, or the keys
for the current group are written too late. This results in a
functionally equivalent config with "misplaced" comments.

Test still passes on Fedora 38. Glib2 versions are:

2.76.4-1.fc38
2.77.0-6.fc39

Cheers
Michael

```
T040-setup: Testing "notmuch setup"
 PASS   Notmuch new without a config suggests notmuch setup
 FAIL   Create a new config interactively
--- T040-setup.2.config-with-comments 2023-07-20 16:58:16.513709261 +0000
+++ T040-setup.2.new-notmuch-config 2023-07-20 16:58:16.513709261 +0000
@@ -1,7 +1,3 @@
-# .notmuch-config - Configuration file for the notmuch mail system
-#
-# For more information about notmuch, see https://notmuchmail.org
-
# Database configuration
#
# The only value supported here is 'path' which should be the top-level
@@ -11,8 +7,6 @@
# configured here named ".notmuch".
#
[database]
-path=/path/to/maildir
-
# User configuration
#
# Here is where you can let notmuch know how you would like to be
@@ -28,11 +22,8 @@
# recipient list of replies, and will set the From address based on the
# address to which the original email was addressed.
#
+path=/path/to/maildir
[user]
-name=Test Suite
-primary_email=test.suite@example.com
-other_email=another.suite@example.com
-
# Configuration for "notmuch new"
#
# The following options are supported here:
@@ -47,9 +38,10 @@
# names will be ignored, independent of its depth/location
# in the mail store.
#
+name=Test Suite
+primary_email=test.suite@example.com
+other_email=another.suite@example.com
[new]
-tags=foo;bar;
-
# Search configuration
#
# The following option is supported here:
@@ -59,9 +51,8 @@
# search results by default.  Using an excluded tag in a
# query will override that exclusion.
#
+tags=foo;bar;
[search]
-exclude_tags=baz
-
# Maildir compatibility configuration
#
# The following option is supported here:
@@ -83,4 +74,5 @@
# and update tags, while the "notmuch tag" and "notmuch restore"
# commands will notice tag changes and update flags in filenames
#
+exclude_tags=baz
[maildir]
 PASS   setup consistent with config-set for single items
```
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: