Re: [PATCH v2] notmuch.vim can now archive threads using a from the show screen

Subject: Re: [PATCH v2] notmuch.vim can now archive threads using a from the show screen

Date: Wed, 4 May 2011 23:11:01 +0300

To: Jeff Richards

Cc: notmuch@notmuchmail.org

From: Felipe Contreras


On Tue, Apr 5, 2011 at 8:31 AM, Jeff Richards <jeff@jrichards.ca> wrote:
> On Mon, 4 Apr 2011 18:58:48 +0300, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> On Mon, Apr 4, 2011 at 4:46 AM, Jeff Richards <jeff@jrichards.ca> wrote:
>> > Implements the already shelled out function for archiving messages while looking at a message.
>>
>> I'm not sure if this should also remove from 'unread', or we should
>> have two actions, one that removes from both unread and 'inbox', and
>> another one only for 'inbox'.
>>
>
> Yep, that's a good point.  Following the functionality for the search screen, the show screen should just remove the inbox tag and that's it.
>
> ---
>  vim/plugin/notmuch.vim |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vim/plugin/notmuch.vim b/vim/plugin/notmuch.vim
> index 67501d8..eae5297 100644
> --- a/vim/plugin/notmuch.vim
> +++ b/vim/plugin/notmuch.vim
> @@ -507,7 +507,7 @@ function! s:NM_show_next_thread()
>  endfunction
>
>  function! s:NM_show_archive_thread()
> -        echo 'not implemented'
> +        call <SID>NM_add_remove_tags(b:nm_search_words, '-', ['inbox'])
>  endfunction
>
>  function! s:NM_show_mark_read_then_archive_thread()
> --
> 1.7.2.3

Actually I had sent a patch for this long time ago:
http://mid.gmane.org/1291933240-5328-1-git-send-email-felipe.contreras@gmail.com

I have pushed that one.

-- 
Felipe Contreras

Thread: