Re: [PATCH] Makefile: specify libnotmuch.so location with -rpath

Subject: Re: [PATCH] Makefile: specify libnotmuch.so location with -rpath

Date: Sun, 25 Apr 2010 17:59:35 +0200

To: Chris Wilson

Cc: notmuch@notmuchmail.org

From: Adrien Bustany


On Sun, 25 Apr 2010 16:38:40 +0100, Chris Wilson
<chris@chris-wilson.co.uk> wrote:
> In order to handle installation into user directories, it is convenient
> to encode the library location into the search path for the notmuch
> executable. This is achieved for the GNU linker with the -rpath
> argument.
> ---
>  Makefile.local |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile.local b/Makefile.local
> index 5bb570b..77d2c45 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc
>  # Smash together user's values with our extra values
>  FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS)
>  $(CONFIGURE_CFLAGS) $(extra_cflags)
>  FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS)
>  $(extra_cflags) $(extra_cxxflags)
> -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch
> +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Wl,-rpath=$(prefix)/lib -Llib
> -lnotmuch
>  FINAL_NOTMUCH_LINKER = CC
>  ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
>  FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS)

Hello Chris,

I know that many distros (among them Fedora, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath )
discourage the use of rpath. Do you think it could be an option set at
configure time (set rpath or not) ?

Cheers

Adrien

Thread: