Re: [PATCH 1/3] new: Do not defer maildir flag synchronization during the first run

Subject: Re: [PATCH 1/3] new: Do not defer maildir flag synchronization during the first run

Date: Fri, 28 Jan 2011 09:51:29 +0100

To: Austin Clements, Carl Worth

Cc: notmuch@notmuchmail.org

From: Sebastian Spaeth


On Thu, 27 Jan 2011 19:08:38 -0500, Austin Clements <amdragon@mit.edu> wrote:

> I added a "notmuch_database_remove_message_get" to the public API that's
> just like "notmuch_database_remove_message" except that it also returns a
> notmuch_message_t if other instances of the message still exist.  It feels
> clunky to have two almost identical variants of this function.  Is this the
> preferred way to change the public API?  Or should I just add the argument
> to the existing function and fix the other three calls to it?

Just adding an argument to the public API without library version bump would
break my python bindings. So if we modify the public API, I would prefer
if we rename the function and remove the old one completely. That I
could detect at least.

Sebastian
part-000.sig (application/pgp-signature)

Thread: