Re: [PATCH] Do not import notmuch in setup.py (again).

Subject: Re: [PATCH] Do not import notmuch in setup.py (again).

Date: Wed, 24 Aug 2011 09:20:51 +0200

To: Michael Hudson-Doyle, notmuch@notmuchmail.org, David Bremner

Cc:

From: Sebastian Spaeth


On Wed, 24 Aug 2011 12:45:34 +1200, Michael Hudson-Doyle <michael.hudson@canonical.com> wrote:
> Revert part of 8826f.  As explained in c39b492c, importing notmuch in setup.py breaks make -f debian/rules clean in an environment that does not have notmuch installed already.

Ahh, sorry, I must have missed that patch (or forgotten about it). I
solved this now by having the version number in version.py (which
contains nothing else, so David Bremner can easily overwrite it with
makefile magic :-)).

@David, feel free to automagically modify (or overwrite)
bindings/python/notmuch/version.py.

We read in version.py using execfile() and verify that getting the
version number actually worked.

Sorry, I did not apply your patch as I had fixed this before even seeing
your patch.

Sebastian
part-000.sig (application/pgp-signature)

Thread: