Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

Date: Tue, 01 Nov 2011 09:30:56 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula <jani@nikula.org> wrote:
> 
> I'm still marking it as RFC. It works for me, but patch 1 might be deemed
> unacceptable.
> 

Hi Jani;

Is just because it add a function to the library that you think this
might be problematic?  I don't think we are super-dogmatic about the
library never growing.  When notmuch started, there were no bindings, so
in retrospect maybe more functionality went into the CLI than might
happen if we started from scratch. If I remember Carl's statement
correctly, one rule is that stuff in the library should not require
configuration.

Just my personal view,

David

• Previous message (by thread): Re: [RFC PATCH v2 3/3] emacs: support limiting the number of results shown in search results

Thread:

• Jani Nikula—[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, notmuch::core, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[RFC PATCH v2 1/3] lib: add function to get the number of threads matching a search [inbox, notmuch::core, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[RFC PATCH v2 2/3] cli: add options --first and --maxitems to notmuch search [inbox, notmuch::core, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[RFC PATCH v2 3/3] emacs: support limiting the number of results shown in search results [inbox, notmuch::core, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—Re: [RFC PATCH v2 3/3] emacs: support limiting the number of results shown in search results [inbox, unread]
      • Jani Nikula—Re: [RFC PATCH v2 3/3] emacs: support limiting the number of results shown in search results [inbox, unread]
  • Jameson Graef Rollins—Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, signed, unread]
    • Jani Nikula—Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, unread]
      • Jameson Graef Rollins—Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, signed, unread]
      • Austin Clements—Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, unread]
  • David Bremner—Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, unread]
    • Jani Nikula—Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results [inbox, unread]