David Bremner <david@tethera.net> writes: > Mark Walters <markwalters1009@gmail.com> writes: > >> Some of the recent changes to the emacs code have used functions >> introduced in emacs 24. The functions used are read-char-choice and >> setq-local. This changeset adds compatability functions to >> notmuch-lib so that it should work on emacs 23. >> --- > >> 1) please could someone with emacs 23 see if the testsuite passes? My >> system with emacs 23 is so outdated the test suite doesn't run (wrong >> python versions I think). > > I get many failures like > > emacsclient.emacs23: connect: Connection refused > emacsclient.emacs23: error accessing socket "/tmp/emacs1000/notmuch-test-suite-21492" > > At a guess, somehow the server is shutting down/dying. I did manage to > manually run an emacs server on this machine, and the socket is being > created in the file system. The plot thickens. With this patch applied, I can generate an emacs segfault with 1) EMACS=emacs23 ./devel/try-emacs-mua -q 2) M-x notmuch-search <return> 3) tag:inbox <return> without the patch, I get a search view, and the message Wrong type argument: number-or-marker-p, entry-main I'm not able to trigger a lisp backtrace.